Feature/mip 03 group events#99
Merged
f7f376a1fcd0d0e11a10ed1b6577c9 merged 3 commits intoHORNET-Storage:mainfrom Feb 18, 2026
Merged
Feature/mip 03 group events#99f7f376a1fcd0d0e11a10ed1b6577c9 merged 3 commits intoHORNET-Storage:mainfrom
f7f376a1fcd0d0e11a10ed1b6577c9 merged 3 commits intoHORNET-Storage:mainfrom
Conversation
…_users Remove early authentication gate in filter handler that blocked unauthenticated users before checking access control settings. The CanRead function already handles all_users mode correctly, so the empty pubkey check was preventing public relay access.
f7f376a1fcd0d0e11a10ed1b6577c9
approved these changes
Feb 18, 2026
Member
f7f376a1fcd0d0e11a10ed1b6577c9
left a comment
f7f376a1fcd0d0e11a10ed1b6577c9
left a comment
There was a problem hiding this comment.
Merging this for now but are we sure we want to allow unauthenticated requests even when all users are allowed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meant relays configured with
all_usersread access still required authenticationCanReadmethod already handles the logic for different access levels, so the pubkey check was redundant and overly restrictive